sql: support in-memory SQL arrays of JSON #70041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
changed the title
postamar
approved these changes
Sep 10, 2021
jordanlewis
force-pushed
the
json-arr
branch
from
804a6a6 to
551e7db
Compare
|
out of curiosity, how do we handle the example from #59427 with this change? |
jordanlewis
force-pushed
the
json-arr
branch
from
551e7db to
1d3ecfa
Compare
rafiss
requested changes
Sep 10, 2021
| @@ -2452,8 +2452,6 @@ func IsStringType(t *T) bool { | |||
| // the issue number should be included in the error report to inform the user. | |||
| func IsValidArrayElementType(t *T) (valid bool, issueNum int) { | |||
There was a problem hiding this comment.
seems like we can remove this function now. unless you think it will be useful to track other types?
There was a problem hiding this comment.
I thought of this, but I figured if we do end up needing something like this again we'll have to remember both of these places and be sad. I think it's fine to leave this in.
|
The behavior is exactly the same. I think Andrew's explanation on that issue makes sense - we can't auto-cast arrays of JSON to json-array. |
rafiss
approved these changes
Sep 10, 2021
jordanlewis
force-pushed
the
json-arr
branch
2 times, most recently
from
4e05409 to
9ebe52a
Compare
This commit adds support for SQL arrays of JSON in memory. This allows functions like `array_agg` to work against JSON objects, which is useful for compatibility. Notably, this commit does not add support for storing JSON arrays in table columns. Release note (sql change): add support for SQL arrays containing JSON for in-memory processing. This does not add support for storing SQL arrays of JSON in tables.
jordanlewis
force-pushed
the
json-arr
branch
from
9ebe52a to
25e38dd
Compare
|
TFTRs 😎 bors r+ |
|
Build succeeded: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #23468
refs #69010
This commit adds support for SQL arrays of JSON in memory. This allows
functions like
array_aggto work against JSON objects, which is usefulfor compatibility.
Notably, this commit does not add support for storing JSON arrays in
table columns.
Release note (sql change): add support for SQL arrays containing JSON
for in-memory processing. This does not add support for storing SQL
arrays of JSON in tables.