Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: clean up large row errors and events #70157

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

michae2
Copy link
Collaborator

@michae2 michae2 commented Sep 13, 2021

Backport 1/1 commits from #70102.

/cc @cockroachdb/release


Addresses: #67400, #69477

Remove ViolatesMaxRowSizeErr from CommonLargeRowDetails, as was done
for CommonTxnRowsLimitDetails in #69945.

Also remove the SafeDetails methods from CommonLargeRowDetails,
txnRowsReadLimitErr, and txnRowsWrittenLimitErr, as I don't think we
need them.

Release justification: low-risk update to new functionality.

Release note: None (there was no release between the introduction of the
LargeRow and LargeRowInternal events and this commit).

@blathers-crl
Copy link

blathers-crl bot commented Sep 13, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Addresses: cockroachdb#67400, cockroachdb#69477

Remove ViolatesMaxRowSizeErr from CommonLargeRowDetails, as was done
for CommonTxnRowsLimitDetails in cockroachdb#69945.

Also remove the SafeDetails methods from CommonLargeRowDetails,
txnRowsReadLimitErr, and txnRowsWrittenLimitErr, as I don't think we
need them.

Release justification: low-risk update to new functionality.

Release note: None (there was no release between the introduction of the
LargeRow and LargeRowInternal events and this commit).
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @knz)

@yuzefovich
Copy link
Member

@knz @rytaft do you think it is justifiable to treat #69477 as a beta release-blocker and, as a result, to merge this? I'm leaning towards treating #69477 as a GA-blocker, so I'd merge this once beta is out.

@knz
Copy link
Contributor

knz commented Sep 17, 2021

agreed with your analysis

@rytaft
Copy link
Collaborator

rytaft commented Sep 17, 2021

Agree, seems like GA-blocker. In which case it can wait till we get approval to merge on Monday.

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

You can go ahead and merge this

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

@michae2
Copy link
Collaborator Author

michae2 commented Sep 20, 2021

TFTRs! Merging.

@michae2 michae2 merged commit dbb3a10 into cockroachdb:release-21.2 Sep 20, 2021
@michae2 michae2 deleted the backport21.2-70102 branch September 20, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants