sql: add consistent testing knobs to all tenants #70231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhartunian
force-pushed
the
fix-grpc-test
branch
from
ab01b0a
to
de531f6
Compare
The tenant gRPC fanout tests that request statement statistics did not consistently apply the testing knob added on the first tenant to the other two. This commit copies the same testing knob value to those tenants. Release note: None
dhartunian
force-pushed
the
fix-grpc-test
branch
from
de531f6
to
0037326
Compare
matthewtodd
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @Azhng)
|
bors r=matthewtodd |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tenant gRPC fanout tests that request statement statistics did not
consistently apply the testing knob added on the first tenant to the
other two. This commit copies the same testing knob value to those
tenants.
Release note: None