sqlsmith: stop ignoring a decimal error #71015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Huh, I'm curious what fixed this :)
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
i also am curious... but i don't feel like bisecting it now :P i realized i should add a test for this case though, so will do that |
Resolved cockroachdb#40929 The error being referenced no longer occurs. Release note: None
rafiss
force-pushed
the
stop-ignoring-40929
branch
from
cade2d1
to
0dd9327
Compare
|
bors r=yuzefovich |
|
bors r- |
|
Canceled. |
|
nevermind, the error still happens under fakedist configuration. sorry, i thought i had tested that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40929
The error being referenced no longer occurs.
Release note: None