[do-not-merge, wrong branch] ui/db-console: surface more job metrics around reverting and retrying in the DBConsole Jobs Overview page #72289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/ui/workspaces/db-console/src/views/jobs/jobTable.fixture.ts
…filtering in the backend
|
This change is |
|
Made the PR with the wrong branch! |
jocrl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: whoops, made this PR from the wrong branch
Resolves #68179
[do-not-merge] Tests are still work in progress. Just wanted to get people's
thoughts in the meantime! Only tests are missing.
This commit surfaces the status
reverting, annotates existingrunningandrevertingstatuses UI with "retrying" where applicable, and adds the "LastExecution Time (UTC)" and "Execution Count" columns to the jobs overview table
in db console. "Retrying" is defined as
status IN ('running', 'reverting') AND next_run > now() AND num_runs > 1.Hovering a retrying status shows the next execution time. The "Status" column
was also moved left to the second column. Filtering using the dropdown by
Status: RunningorStatus: Revertingwill include those that arealso "retrying". Users can also filter by
Status: Retrying.The
/jobsendpoint was modified to add thelast_run,next_run, andnum_runsfields required for the UI change. Jobs with statusrunningorrevertingand are also "retrying" have their statuses sent asretry-runningand
retry-revertingrespectively. The endpoint was also modified to supportthe value
retryingfor thestatusquery parameter.This commit also adds a storybook story for the jobs table, which showcases the
different possible statuses in permutations of information that could be
present for the
runningstatus.Release note (ui change): The jobs overview table in DBConsole now shows when
jobs have the status "reverting", and shows the badge "retrying" when running
or reverting jobs are also retrying. Hovering the status for a "retrying" job
will show the "Next execution time" in UTC. Two new columns, "Last Execution
Time (UTC)" and "Execution Count", were also added to the jobs overview table
in DBConsole, and the "Status" column was moved left to the second column in
the table.
The
statusquery parameter in the/jobsendpoint now supports the valuesrevertingandretrying.Jobs table:
Filter and hover:
https://user-images.githubusercontent.com/91907326/139694374-e11d0b4e-f9ba-4625-8aca-314786638c8c.mov
Permutations of running jobs with combination of time remaining, running message, or retrying present/absent:
