Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: tenant pods fan out to cancel SQL sessions and queries #72344

Merged
merged 2 commits into from
Nov 15, 2021
Merged

release-21.2: tenant pods fan out to cancel SQL sessions and queries #72344

merged 2 commits into from
Nov 15, 2021

Conversation

matthewtodd
Copy link
Contributor

@matthewtodd matthewtodd commented Nov 2, 2021 •
edited
Loading

Backport:

Please see individual PRs for details.

Release justification: Category 3. These endpoints are necessary to make the "terminate session" and "terminate query" buttons work in Cockroach Cloud.

/cc @cockroachdb/release

@matthewtodd
server: Tenant pods fan out to cancel SQL sessions
22a677e 
Partially addresses #70832.

Previously, the tenant `/_status/cancel_session` endpoint was not
available over HTTP and could not cancel a session not running locally.
This change opens it up, so that we can call it from the cloud console,
and makes sure that that we can cancel sessions when a tenant has more
than one SQL pod running.

Release note (api change): The tenant `/_status/cancel_session` endpoint
was made available over HTTP and augmented to fan out requests in a
multi-pod world.
@matthewtodd
server: Tenant pods fan out to cancel SQL queries
da5dba2 
Partially addresses #70832.

Previously, the tenant `/_status/cancel_query` endpoint was not
available over HTTP and could not cancel a query not running locally.
This change opens it up, so that we can call it from the cloud console,
and makes sure that that we can cancel queries when a tenant has more
than one SQL pod running.

Release note (api change): The tenant `/_status/cancel_query` endpoint
was made available over HTTP and augmented to fan out requests in a
multi-pod world.
@matthewtodd matthewtodd requested a review from a team as a code owner November 2, 2021 19:08
@blathers-crl
Copy link

blathers-crl bot commented Nov 2, 2021 •
edited by matthewtodd
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@matthewtodd matthewtodd added the do-not-merge bors won't merge a PR with this label. label Nov 2, 2021
@matthewtodd matthewtodd removed the do-not-merge bors won't merge a PR with this label. label Nov 15, 2021
@matthewtodd matthewtodd requested a review from a team November 15, 2021 20:15
@matthewtodd matthewtodd merged commit cbe3347 into cockroachdb:release-21.2 Nov 15, 2021
@matthewtodd matthewtodd deleted the backport21.2-71174-71503 branch November 15, 2021 20:32
This was referenced Nov 15, 2021
Closed
Closed
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Nov 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewtodd @cockroach-teamcity @maryliag