sql: handle no cluster_inflight_traces table on tenants #72825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
reviewed
Nov 16, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @aliher1911)
pkg/sql/crdb_internal.go, line 1293 at r1 (raw file):
if traceCollector == nil { // Tenant nodes doesn't have trace collector so can't serve this table. return false, pgerror.New(pgcode.UndefinedTable, "table crdb_internal.cluster_inflight_traces does not exist")
The error can be confusing, especially if the table shows up in internal catalogs. I would check !planner.ExecCfg().Codec.ForSystemTenant instead and emit an error saying this is not implemented for tenants.
aliher1911
force-pushed
the
multi_tenant_no_trace
branch
2 times, most recently
from
32a7262
to
f610523
Compare
|
Or is it better to add the test to pkg/sql/logictest/testdata/logic_test/crdb_internal_tenant ? |
aliher1911
force-pushed
the
multi_tenant_no_trace
branch
from
f610523
to
7a3f74c
Compare
adityamaru
approved these changes
Nov 18, 2021
Previously query for traces under tenant will fail with NPE. This was happening because trace collector is not available and virtual table was not aware of the case. This patch adds handling of the table on tenant sql pods. Release note: None
aliher1911
force-pushed
the
multi_tenant_no_trace
branch
from
7a3f74c
to
18ebda3
Compare
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously query for traces under tenant will fail with NPE.
This was happening because trace collector is not available
and virtual table was not aware of the case.
This patch adds handling of the table on tenant sql pods.
Release note: None
Fixes #72564