Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: don't include tenants in non-cluster backups #72871

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

dt
Copy link
Member

@dt dt commented Nov 17, 2021

Release note (bug fix): System tenant backups of individual tables and databases no longer include tenants as well.

Release note (bug fix): System tenant backups of individual tables and databases no longer include tenants as well.
@dt dt requested review from stevendanna and a team November 17, 2021 15:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test as well. I think this looks good as a backportable fix.

@dt
Copy link
Member Author

dt commented Nov 18, 2021

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 18, 2021

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Nov 18, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from ddd8761 to blathers/backport-release-21.1-72871: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@dt dt deleted the tenant-inclusion-bug branch November 22, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-21.1.x 21.1 is EOL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants