Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server,ccl: replace a few usages of keys.TODOSQLCodec #72876

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

e-mbrown
Copy link
Contributor

references #48123

Replaced a few instances of keys.TODOSQLCodec with proper codecs.

Release note: None

@e-mbrown e-mbrown requested a review from a team November 17, 2021 16:54
@e-mbrown e-mbrown requested a review from a team as a code owner November 17, 2021 16:54
@e-mbrown e-mbrown requested review from msbutler and HonoreDB and removed request for a team November 17, 2021 16:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in restore_planning looks good to me! Maybe worth asking someone on server about your question in server/admin.go.

@e-mbrown e-mbrown force-pushed the eb/removecodec branch 2 times, most recently from 7c6854b to 7104877 Compare November 30, 2021 16:21
references cockroachdb#48123

Replaced a few instances of keys.TODOSQLCodec with proper
codecs.

Release note: None
@e-mbrown
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 30, 2021

Build succeeded:

@craig craig bot merged commit 2e038a1 into cockroachdb:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants