build/builder: install awscli v2

[erikgrinaker]

roachprod requires awscli v2, but the builder image included v1.

Release note: None

[cockroach-teamcity]

This change is 

[rail]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker, @rail, and @rickystewart)

---

build/builder/Dockerfile, line 173 at r2 (raw file):

  unzip awscliv2.zip && \
  ./aws/install && \
  rm -rf awscliv2.zip aws

Can we pin the version, like we do for roachprod:

cockroach/pkg/cmd/roachprod/docker/build.sh

Lines 32 to 37 in e1c7d6a

	# Debian ships with awscli version 1.x, which is unsupported by roachprod.
	# Install aws-cli using the official instructions from
	# https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
	curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.0.30.zip" -o "awscliv2.zip"
	sha256sum -c - <<EOF
	7ee475f22c1b35cc9e53affbf96a9ffce91706e154a9441d0d39cbf8366b718e awscliv2.zip

[rail]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker, @rail, and @rickystewart)

---

build/builder/Dockerfile, line 173 at r2 (raw file):

Previously, rail (Rail Aliiev) wrote…

Can we pin the version, like we do for roachprod:

cockroach/pkg/cmd/roachprod/docker/build.sh

Lines 32 to 37 in e1c7d6a

	# Debian ships with awscli version 1.x, which is unsupported by roachprod.
	# Install aws-cli using the official instructions from
	# https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
	curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.0.30.zip" -o "awscliv2.zip"
	sha256sum -c - <<EOF
	7ee475f22c1b35cc9e53affbf96a9ffce91706e154a9441d0d39cbf8366b718e awscliv2.zip

cockroach/pkg/cmd/roachprod/docker/build.sh

Lines 32 to 41 in e1c7d6a

	# Debian ships with awscli version 1.x, which is unsupported by roachprod.
	# Install aws-cli using the official instructions from
	# https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
	curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.0.30.zip" -o "awscliv2.zip"
	sha256sum -c - <<EOF
	7ee475f22c1b35cc9e53affbf96a9ffce91706e154a9441d0d39cbf8366b718e awscliv2.zip
	EOF
	unzip awscliv2.zip
	./aws/install
	rm -rf aws awscliv2.zip

rather

[erikgrinaker]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rail and @rickystewart)

---

build/builder/Dockerfile, line 173 at r2 (raw file):

Previously, rail (Rail Aliiev) wrote…

cockroach/pkg/cmd/roachprod/docker/build.sh

Lines 32 to 41 in e1c7d6a

	# Debian ships with awscli version 1.x, which is unsupported by roachprod.
	# Install aws-cli using the official instructions from
	# https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
	curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.0.30.zip" -o "awscliv2.zip"
	sha256sum -c - <<EOF
	7ee475f22c1b35cc9e53affbf96a9ffce91706e154a9441d0d39cbf8366b718e awscliv2.zip
	EOF
	unzip awscliv2.zip
	./aws/install
	rm -rf aws awscliv2.zip

rather

Good call, done.

[erikgrinaker]

This breaks the AWS nightly tests. It would be great if we could merge this and push a new image before the next nightly run.

[erikgrinaker]

Going to skip CI on this one, image is pushed and builder.sh works. TFTR!

bors r=rail

[craig]

Build succeeded:

• GitHub CI (Cockroach)