parser: implement ALTER TABLE ... RESET (...) #75429
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Jan 27, 2022
Merged
parser: implement ALTER TABLE ... RESET (...) #75429craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rafiss
approved these changes
Jan 26, 2022
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
lgtm! just a nit for comments
Reviewed 2 of 3 files at r1, 3 of 5 files at r3, 9 of 9 files at r4, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/paramparse/paramobserver.go, line 85 at r4 (raw file):
onSet(evalCtx *tree.EvalContext, key string, datum tree.Datum) error onReset(evalCtx *tree.EvalContext, key string) error runPostChecks() error
nit: could use comments on all of the interface methods
Contributor
Author
|
done! bors r=rafiss |
Contributor
|
Canceled. |
Contributor
Author
|
oops, pushed the wrong branch bors r=rafiss |
Contributor
|
Build failed (retrying...): |
This is a minor refactor of the paramparse package to prepare for implementing the ALTER TABLE ... RESET (...) syntax. Actions * Rename the receivers from `a` to `po`. * Make methods on `ParamObserver` interface private. * Rename `Apply` to `Set. * Make the table parameters a map. Release note: None
Contributor
Author
|
conflict ... bors r- |
Contributor
|
Canceled. |
Also includes pieces here which will pave the way for implementing the TTL syntax. Release note (sql change): Implemented the `ALTER TABLE ... RESET (...)` syntax. This is currently a no-op operation.
Release note: None
Contributor
Author
|
bors r=rafiss |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only last two commits for review (rest is #75262).
See individual commits for details.