ttljob: add metrics to row level TTL#76701
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 21, 2022
Merged
Conversation
Member
|
This change is |
otan
force-pushed
the
metrics
branch
2 times, most recently
from
45d547d to
a2c2dba
Compare
miretskiy
suggested changes
Feb 17, 2022
miretskiy
approved these changes
Feb 17, 2022
rafiss
requested changes
Feb 17, 2022
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
minor nits and questions
Collaborator
|
double post'd! |
otan
force-pushed
the
metrics
branch
2 times, most recently
from
d6f2ad4 to
3102d51
Compare
otan
force-pushed
the
metrics
branch
2 times, most recently
from
a782405 to
86690e8
Compare
This commit adds metrics about the row-level TTL job. Note new metrics are created on a per-TTL table basis, which forms the basis of the "relation" label. This allows monitoring of TTL jobs per table. Release note: None
Contributor
Author
|
bors r+ assuming nits are non-blocking, they've all been addressed! |
Contributor
|
Build succeeded: |
miretskiy
reviewed
Feb 21, 2022
| } | ||
|
|
||
| func makeRowLevelTTLAggMetrics(histogramWindowInterval time.Duration) metric.Struct { | ||
| sigFigs := 2 |
Contributor
There was a problem hiding this comment.
btw, are we sure we want sigFigs=2? Wouldn't 1 be sufficient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds metrics about the row-level TTL job. Note new metrics
are created on a per-TTL table basis, which forms the basis of the
"relation" label. This allows monitoring of TTL jobs per table.
Release note: None