Skip to content

ttljob: add controls to pause TTL jobs#76835

Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom
otan-cockroach:feature_flag
Feb 23, 2022
Merged

ttljob: add controls to pause TTL jobs#76835
craig[bot] merged 3 commits intocockroachdb:masterfrom
otan-cockroach:feature_flag

Conversation

@otan
Copy link
Contributor

@otan otan commented Feb 21, 2022

See individual commits for details.

@otan otan requested review from a team and rafiss February 21, 2022 03:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan mentioned this pull request Feb 21, 2022
30 tasks
@otan otan force-pushed the feature_flag branch 6 times, most recently from 4e2ea6e to 779c309 Compare February 22, 2022 11:09
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! had some optional nits and a question

otan added 2 commits February 23, 2022 07:55
This commit disables TTL job execution if the CLUSTER SETTING
sql.ttl.job.enabled is set to false.

Release note: None
This commit introduces ttl_pause as a table storage parameter, pausing
TTL job for only the given table.

Release note: None
@otan
Copy link
Contributor Author

otan commented Feb 22, 2022

thanks!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Feb 22, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build failed (retrying...):

@otan
Copy link
Contributor Author

otan commented Feb 23, 2022

bors r-

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Canceled.

@otan
Copy link
Contributor Author

otan commented Feb 23, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build succeeded:

@craig craig bot merged commit 5522769 into cockroachdb:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments