colexecspan: de-templatize span assembler and use span.Splitter#76901
colexecspan: de-templatize span assembler and use span.Splitter#76901craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
647648b to
807fe6c
Compare
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 6 of 6 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
-- commits, line 2 at r1:
In order to not break the build (and keep the bisect working), we need to do the same changes in span_assembler_gen.go and colexecspan/BUILD.bazel.
pkg/sql/span/span_splitter.go, line 87 at r3 (raw file):
} // FamilyIDs returns the family IDs into which spans will be split, or nil if
nit: maybe add this as a comment on neededFamilies too.
The span assembler code is generated only to inline a piece of code that has two variants. This change converts it to non-generated code and simply forks the code paths above the batch loop. Release note: None
The span assembler duplicates some of the logic in `span.Splitter`. Now that the latter is a separate type, we can use it instead. Release note: None
807fe6c to
9b6a2f1
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Previously, yuzefovich (Yahor Yuzefovich) wrote…
In order to not break the build (and keep the bisect working), we need to do the same changes in
span_assembler_gen.goandcolexecspan/BUILD.bazel.
I just squashed the commits, it was only to make the review easier.
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
colexecspan: de-templatize span assembler
The span assembler code is generated only to inline a piece of code
that has two variants. This change converts it to non-generated code
and simply forks the code paths above the batch loop.
Release note: None
colexecspan: use span.Splitter
The span assembler duplicates some of the logic in
span.Splitter.Now that the latter is a separate type, we can use it instead.
Release note: None