sql: skip flaky schema_changer/drop_database_cascade test #77049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Member
|
This change is |
postamar
approved these changes
Feb 25, 2022
postamar
left a comment
postamar
left a comment
There was a problem hiding this comment.
LGTM. This test was meant to exercise the legacy schema changer so I have no issue disabling part or all of it.
I suspect that we'll have to reconsider our assumptions in all of these TestRevertingJobsOnDatabasesAndSchemas tests and fix them. It's a good thing that it's testing but the completion criteria might need some tweaking. We'll take care of that, thanks for creating the issue.
Contributor
Author
|
Thanks! bors r=postamar |
Contributor
|
Build succeeded: |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None