jobs: Ensure schedules are cancelled when scheduler disabled. #77306
Conversation
|
This change is |
miretskiy
force-pushed
the
disable_scheduler
branch
from
dc1e43d
to
ec0079f
Compare
pkg/jobs/job_scheduler.go
Outdated
| type syncCancelFunc struct { | ||
| syncutil.Mutex | ||
| context.CancelFunc | ||
| sv *settings.Values |
There was a problem hiding this comment.
do we need to capture sv? don't we have it at the withCancelOnDisabled callsite too?
There was a problem hiding this comment.
yeah; we could pass it in...done.
miretskiy
force-pushed
the
disable_scheduler
branch
from
ec0079f
to
fa13954
Compare
Ensure that currently executing schedules are cancelled immediately when jobs scheduler disabled via the `jobs.scheduler.enabled` setting. Fixes cockroachdb#77248 Release Note (enterprise change): Currently executing schedules are cancelled immediately when jobs scheduler disabled. Release Justification: stability improvement.
miretskiy
force-pushed
the
disable_scheduler
branch
from
fa13954
to
3661ab1
Compare
|
Informs #70920 |
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating backport branch refs/heads/blathers/backport-release-21.1-77306: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 21.1.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-21.2-77306: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Ensure that currently executing schedules are cancelled immediately
when jobs scheduler disabled via the
jobs.scheduler.enabledsetting.Fixes #77248
Release Note (enterprise change): Currently executing schedules are
cancelled immediately when jobs scheduler disabled.
Release Justification: stability improvement.