Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: remove roachpb from tree #80842

Merged
merged 1 commit into from
May 2, 2022
Merged

parser: remove roachpb from tree #80842

merged 1 commit into from
May 2, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented May 2, 2022 •
edited
Loading

Reacting on an earlier comment which I misunderstood. Delete roachpb
from parser as it is no longer a dependency.

Refs: #79357

Release note: None

@otan otan requested a review from irfansharif May 2, 2022 00:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

irfansharif
irfansharif approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks bro

@otan
parser: remove roachpb from tree
4b156af 
Reacting on an earlier comment which I misunderstood. Delete roachpb
from parser as it is no longer a dependency.

Release note: None
@otan otan force-pushed the sigh_i_cant_read branch from 9e95dd1 to 4b156af Compare May 2, 2022 03:34
@otan
Copy link
Contributor Author

otan commented May 2, 2022

bors r=irfansharif

@craig
Copy link
Contributor

craig bot commented May 2, 2022

Build succeeded:

@craig craig bot merged commit 7a9eb90 into cockroachdb:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otan @cockroach-teamcity @irfansharif