Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: fix raft handling stats when no ready present #81660

Merged
merged 1 commit into from
May 23, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented May 23, 2022

We were previously adding time.Time{}.Sub(timeutil.Now()) to
the metrics some of the time which produces bogus results.

Noticed while working on #81516.

Release note: None

We were previously adding `time.Time{}.Sub(timeutil.Now()` to
the metrics which produces bogus results.

Release note: None
@tbg tbg requested a review from a team May 23, 2022 13:02
@tbg tbg requested a review from a team as a code owner May 23, 2022 13:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member Author

tbg commented May 23, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented May 23, 2022

Build succeeded:

@craig craig bot merged commit 1d09af8 into cockroachdb:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants