Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: add custom shadow lint #81760

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

rickystewart
Copy link
Collaborator

We explicitly ignore variables named err, pErr, and ctx.

Closes #73069.

Release note: None

@rickystewart rickystewart requested review from a team as code owners May 24, 2022 17:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

We explicitly ignore variables named `err`, `pErr`, and `ctx`.

Closes cockroachdb#73069.

Release note: None
@rickystewart
Copy link
Collaborator Author

TFTR!

bors r=rail

Copy link
Contributor

@mari-crl mari-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)

@craig
Copy link
Contributor

craig bot commented May 26, 2022

Build succeeded:

@craig craig bot merged commit 9188443 into cockroachdb:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: add custom shadow Analyzer that ignores err shadowing
4 participants