sql/builtins: remove dependency to sql/randgen #83718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Xiang-Gu
force-pushed
the
break_dep_drom_builtins_to_randgen
branch
from
cbd434e to
542bc3a
Compare
ajwerner
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
|
bors r+ |
|
bors r- I realized that the added |
|
Canceled. |
Previously, a test in the `builtins` package depended on `randgen`. This was inadequate because it will introduce a dependency cycle later when we introduce the dependency from `tabledesc` to `builtins`, as required to implement some sequence reference releated issues (see pr cockroachdb#82172 for details). Release note: None
Xiang-Gu
force-pushed
the
break_dep_drom_builtins_to_randgen
branch
from
542bc3a to
6d5fc13
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a test in the
builtinspackage depended onrandgen.This was inadequate because it will introduce a dependency cycle later
when we introduce the dependency from
tabledesctobuiltins, asrequired to implement some sequence reference releated issues (see
pr #82172 for details).
Release note: None