storage: use block-property filters for MVCC range tombstone masking #85576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
LGTM, modulo test failures.
nit: MVCCDeleteRange doesn't use a range tombstone, it's a legacy function that drops point tombstones across keys in a span. The real method is the unfortunately named MVCCDeleteRangeUsingTombstone. I'd just refer to them as MVCC range keys/tombstones.
nicktrav
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
jbowens
force-pushed
the
use-bpf-masking
branch
from
c77a4fb
to
9d81b09
Compare
jbowens
changed the title
Use block-property filters to aid in skipping keys that are deleted by a MVCC range tombstone. Release note: None
jbowens
force-pushed
the
use-bpf-masking
branch
from
9d81b09
to
3a0e0e0
Compare
|
TFTRs! bors r=nicktrav,erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use block-property filters to aid in skipping keys that are deleted by a
MVCC range tombstone.
Release note: None