streamingccl: multi-node unit tests #85735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
samiskin
force-pushed
the
streaming-multinode-tests
branch
4 times, most recently
from
7c86185
to
4e170b7
Compare
None of our tests used to run with multiple nodes and a scattered table, so this PR re-enables the unvavailable node test and creates a new basic multinode test. Release note: None
samiskin
force-pushed
the
streaming-multinode-tests
branch
from
4e170b7
to
e39d25b
Compare
gh-casper
reviewed
Aug 11, 2022
|
@gh-casper The issue didn't end up happening anymore, at least not like it used to, so I think it was somehow fixed by one of the PRs that were in flight at the time. The only bug fix here was around the creation statement being retried, added that to the description now 👍 It's likely that #85866 was the issue I was seeing during the roachprod demo. |
gh-casper
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @samiskin)
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of our tests used to run with multiple nodes and a scattered table,
so this PR re-enables the unavailable node test and creates a new basic
multinode test.
It also fixes a bug where if the stream creation statement was retried, it
would now error on an existing tenant, since the tenant creation wasn't
associated with the overall transaction.
Release note: None