Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/rowexec: check MustBeStreaming on instantiated generators #85802

Closed
wants to merge 1 commit into from
Closed

sql/rowexec: check MustBeStreaming on instantiated generators #85802

wants to merge 1 commit into from

Commits on Aug 9, 2022

  1. sql/rowexec: check MustBeStreaming on instantiated generators 

    In projectSetProcessor, the `gen` array is not populated until
nextInputRow() is called in Next.  But, we expected that these
generators had been populated in MustBeStreaming which is called
before Next() is called.

As a result, rows returned streaming value generators were still
buffered.

I believe this is the main cause of cockroachdb#85630 and other odd behaviour
we've seen in the tenant replication tests.

Release note: None
    @stevendanna
    stevendanna committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ad7e9b9 View commit details
    Browse the repository at this point in the history