Commits on Oct 21, 2022

1. server: write pebble log messages to storage channel …

   Previously, when setting up the server, the pebble engine would be
   initialized with Pebble's default logger. The reason for this is that
   the pebble initialization code calls `EnsureDefaults` on the
   configuration options _before_ checking if the `options.Logger` is
   nil/unset. At that point, it will never be unset, as `EnsureDefaults`
   will set the logger to `pebble.DefaultLogger` if it was not previously
   set.
   
   This change overwrites the pebble logger if its found to be the
   `DefaultLogger`. We never want to use pebble's `DefaultLogger` in CRDB
   as that would mean pebble would use the standard library `log`
   package, making every message emitted by Pebble to be treated as
   `INFO` level messages, regardless of severity (including `log.Fatal`
   calls).
   
   Related to #83079.
   
   Fixes #72683.
   Fixes #90483.
   
   Release note: None.

   

   renatolabs committed Oct 21, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 3cae346
   • Browse repository at this point

   Copy the full SHA

   3cae346 View commit details

   Browse the repository at this point in the history