Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvcoord: return error on failed scan response checksum #92257

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Nov 21, 2022

Found in #89477.

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

tbg added a commit to tbg/cockroach that referenced this pull request Nov 21, 2022
revert checksum changes

they have their own PR: cockroachdb#92257
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this a test case too.

tbg added a commit to tbg/cockroach that referenced this pull request Nov 29, 2022
revert checksum changes

they have their own PR: cockroachdb#92257
tbg added a commit to tbg/cockroach that referenced this pull request Dec 2, 2022
revert checksum changes

they have their own PR: cockroachdb#92257
@tbg tbg marked this pull request as ready for review December 7, 2022 14:55
@tbg tbg requested a review from a team as a code owner December 7, 2022 14:55
@tbg tbg requested a review from erikgrinaker December 7, 2022 14:55
@tbg
Copy link
Member Author

tbg commented Dec 7, 2022

Test added, PTAL.

Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tbg
Copy link
Member Author

tbg commented Dec 7, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Dec 7, 2022

Build succeeded:

@craig craig bot merged commit 063fbc6 into cockroachdb:master Dec 7, 2022
@tbg tbg deleted the scan-checksums branch December 8, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants