Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: convert TSVECTOR and TSQUERY to JSON elements as strings #93011

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

msirek
Copy link
Contributor

@msirek msirek commented Dec 5, 2022

Fixes #92998

This adds support for converting TSVECTOR and TSQUERY data types to JSON elements via functions such as json_build_array.

Release note: None

Fixes cockroachdb#92998

This adds support for converting TSVECTOR and TSQUERY data
types to JSON elements via functions such as json_build_array.

Release note: None
@msirek msirek requested review from jordanlewis and a team December 5, 2022 06:14
@msirek msirek requested a review from a team as a code owner December 5, 2022 06:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)

@jordanlewis
Copy link
Member

Thank you for the quick fix.

Copy link
Contributor Author

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!
bors r=rytaft,jordanlewis

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msirek)

@craig
Copy link
Contributor

craig bot commented Dec 5, 2022

Build succeeded:

@craig craig bot merged commit 969e6aa into cockroachdb:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: sqlsmith/setup=seed/setting=no-mutations failed
4 participants