Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvnemesis: ignore SysBytes:10 MVCC stats discrepancy #93897

Merged
merged 1 commit into from
Dec 19, 2022
Merged

kvnemesis: ignore SysBytes:10 MVCC stats discrepancy #93897

merged 1 commit into from
Dec 19, 2022

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Dec 19, 2022 •
edited
Loading

Resolves #93890.
Touches #93896.
Touches #93312.
Touches #86542.

Epic: none
Release note: None

@erikgrinaker erikgrinaker requested review from tbg and a team December 19, 2022 11:47
@erikgrinaker erikgrinaker self-assigned this Dec 19, 2022
@erikgrinaker erikgrinaker requested a review from a team as a code owner December 19, 2022 11:47
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker mentioned this pull request Dec 19, 2022
Open
@erikgrinaker erikgrinaker force-pushed the kvnemesis-ignore-sysbytes branch from 32cd78e to 398dfc7 Compare December 19, 2022 11:51
tbg
tbg approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but shouldn't this be filed and the issue linked?

@erikgrinaker
Copy link
Contributor Author

It was filed and linked, but not from the PR description. Updated.

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build succeeded:

@craig craig bot merged commit a34ab92 into cockroachdb:master Dec 19, 2022
@erikgrinaker erikgrinaker deleted the kvnemesis-ignore-sysbytes branch December 28, 2022 11:23
@erikgrinaker erikgrinaker mentioned this pull request Jan 9, 2023
Closed
@pav-kv pav-kv mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

Assignees

@erikgrinaker erikgrinaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kv/kvnemesis: TestKVNemesisMultiNode failed
3 participants
@erikgrinaker @cockroach-teamcity @tbg