schemachanger: a bunch of small fixes #95467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
added 5 commits
January 19, 2023 06:52
Previously, it was impossible to execute EXPLAIN (DDL) COMMENT ON... This commit fixes this. Release note (bug fix): EXPLAIN (DDL) COMMENT ON is now possible.
This commit fixes a bug with this function which only becomes apparent when not using bazel. This only impacts testing with GoLand. Release note: None
In some cases, we define a set of almost-identical rules with the same name, purposefully. The name is what is used by the data-driven test output to sort the rule definitions, because these otherwise appear in the order that the init() functions were called, which is undefined. Sorting by name reduced the instability of the data-driven test when adding or removing init() blocks containing rule definitions, but did not altogether remove it. This commit should help further remove it by using a stable sort. In this way, the test output should be stable assuming that rule names are not re-used across init() blocks. Release note: None
This operation is no longer required. Release note: None
This commit fixes a bug where comments weren't handled correctly by the test state. This wasn't noticeable because the code wasn't actually exercised anywhere. This commit also fixes this. Release note: None
postamar
force-pushed
the
declarative-schema-changer-small-fixes
branch
from
8979538 to
fc10b6d
Compare
postamar
requested review from
rytaft
and removed request for
a team and
rytaft
ajwerner
approved these changes
Jan 19, 2023
Author
|
Thanks for the review! |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #88294.
Release note: None