testlogic: deflake new_schema_changer test case #95826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected output of a system.eventlog query was rewritten in e333a39 with more than one record but the query was missing an ORDER clause, leading to non-deterministic output. This commit fixes this by adding the missing ORDER clause. Fixes cockroachdb#95825. Release note: None
|
This change is |
ajwerner
approved these changes
Jan 25, 2023
|
I'm aware, I just conformed to the existing pattern. This is one of these cases where UDFs would be useful. Perhaps there's room for a testlogic-wide body of UDFs which automatically get added after |
|
bors r+ |
|
bors r+ p=999 |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected output of a system.eventlog query was rewritten in e333a39 with more than one record but the query was missing an ORDER clause, leading to non-deterministic output. This commit fixes this by adding the missing ORDER clause.
Fixes #95825.
Release note: None