sql: refactor FunctionProperties and Overload #96126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgartner
requested review from
cucaroach and
HonoreDB
and removed request for
a team
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
HonoreDB
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 16 of 18 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @cucaroach)
mgartner
force-pushed
the
func-class-refactor
branch
from
acef311 to
3004806
Compare
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
mgartner
force-pushed
the
func-class-refactor
branch
2 times, most recently
from
28c0060 to
7c44c96
Compare
`FuncExpr.IsGeneratorApplication` has been removed and its single usage has been replaced with with `FuncExpr.IsGeneratorClass`. Release note: None
`FunctionProperties` are attached to a `FunctionDefinition`, which is simply a collection of overloads that share the same name. Most of the fields in `FunctionProperties` are, however, overload-specific. They should be moved to the `Overload` struct. In the long-term, the hierarchy of function definitions, each with child function overloads, should be flattened to a just overloads. This commit takes one step in this direction. Epic: CRDB-20370 Release note: None
mgartner
force-pushed
the
func-class-refactor
branch
from
7c44c96 to
ddb8efb
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: remove FuncExpr.IsGeneratorApplication
FuncExpr.IsGeneratorApplicationhas been removed and its single usagehas been replaced with with
FuncExpr.IsGeneratorClass.Release note: None
sql: move FunctionClass from FunctionProperties to Overload
FunctionPropertiesare attached to aFunctionDefinition, which issimply a collection of overloads that share the same name. Most of the
fields in
FunctionPropertiesare, however, overload-specific. Theyshould be moved to the
Overloadstruct. In the long-term,the hierarchy of function definitions, each with child function overloads,
should be flattened to a just overloads.
This commit takes one step in this direction.
Epic: CRDB-20370
Release note: None