sql: add user_id column to system.database_role_settings table

[andyyang890]

This patch adds a new role_id column to the system.database_role_settings
table, which corresponds to the existing role_name column. Migrations are
also added to alter and backfill the table in older clusters.

Part of #87079

Release note: None

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[rafiss]

looks good overall! i just had one comment about using a STORING index

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @andyyang890)

---

pkg/upgrade/upgrades/database_role_settings_table_user_id_migration.go line 31 at r1 (raw file):

const createUniqueIndexOnDatabaseIDAndRoleIDOnDatabaseRoleSettingsTableStmt = `
CREATE UNIQUE INDEX IF NOT EXISTS database_role_settings_database_id_role_id_key
ON system.database_role_settings (database_id, role_id)

similar to system.privileges, i think this would benefit from having STORING (settings) on it. (if you look at the query where the table is accessed, it always needs to fetch the settings column)

[andyyang890]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/upgrade/upgrades/database_role_settings_table_user_id_migration.go line 31 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

similar to system.privileges, i think this would benefit from having STORING (settings) on it. (if you look at the query where the table is accessed, it always needs to fetch the settings column)

Done.

[rafiss]

lgtm!

Reviewable status: complete! 0 of 0 LGTMs obtained

[andyyang890]

TFTR!

bors r=rafiss

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)