Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: introduce array_cat_agg aggregate builtin #98171

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Mar 7, 2023

Backport 1/1 commits from #97826.

/cc @cockroachdb/release


This commit introduces a new array_cat_agg aggregate builtin function
that takes in an array type as its input, and then unnests each array
and appends all its elements into a single result array. In other
words, it behaves similar to array_agg(unnest(array_column)). This
function doesn't have an analogue in Postgres. However, some of our SQL
observability tools need this functionality, and the current workaround
of using a LATERAL JOIN often results in slow apply joins, so this new
builtin should speed things up significantly. In particular,
crdb_internal.statement_statistics view is now refactored to use the
new builtin which removes an apply join from it. The choice of this
particular name comes from the fact that we have the array_cat builtin
which concatenates two arrays.

Fixes: #97502.

Release note (sql change): New aggregate builtin function
array_cat_agg is introduced. It behaves similar to how
array_agg(unnest(array_column)) would - namely, it takes arrays as its
input, unnests them into the array elements which are then aggregated
into a single result array (i.e. it's similar to concatenating all input
arrays into a single one).

Release justification: performance improvement of observability tooling.

@yuzefovich yuzefovich requested review from rytaft, DrewKimball and a team March 7, 2023 20:30
@yuzefovich yuzefovich requested a review from a team as a code owner March 7, 2023 20:30
@blathers-crl
Copy link

blathers-crl bot commented Mar 7, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit introduces a new `array_cat_agg` aggregate builtin function
that takes in an array type as its input, and then unnests each array
and appends all its elements into a single result array. In other
words, it behaves similar to `array_agg(unnest(array_column))`. This
function doesn't have an analogue in Postgres. However, some of our SQL
observability tools need this functionality, and the current workaround
of using a LATERAL JOIN often results in slow apply joins, so this new
builtin should speed things up significantly. In particular,
`crdb_internal.statement_statistics` view is now refactored to use the
new builtin which removes an apply join from it. The choice of this
particular name comes from the fact that we have the `array_cat` builtin
which concatenates two arrays.

Release note (sql change): New aggregate builtin function
`array_cat_agg` is introduced. It behaves similar to how
`array_agg(unnest(array_column))` would - namely, it takes arrays as its
input, unnests them into the array elements which are then aggregated
into a single result array (i.e. it's similar to concatenating all input
arrays into a single one).
@yuzefovich yuzefovich force-pushed the backport22.2-97826 branch from 7289e78 to 02fb46e Compare March 7, 2023 22:00
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: assuming the oid changes are ok

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @yuzefovich)


pkg/sql/logictest/testdata/logic_test/pg_catalog line 3273 at r1 (raw file):

WHERE t.typname = '_int4'
----
2046  array_in  array_in

Are these changes ok? (this file and pgoidtype)


pkg/sql/function_resolver_test.go line 370 at r1 (raw file):

			searchPath:       []string{"sc1", "sc2"},
			expectedFuncBody: "",
			expectedFuncOID:  853,

is this change ok?

@yuzefovich
Copy link
Member Author

TFTR! The oid changes are ok - we didn't have fixed oids until 5ee5d85 which is only present on 23.1 development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants