kvserver: revert recent changes to reproposals#98481

Merged

craig[bot] merged 11 commits intocockroachdb:masterfrom tbg:revert-reproposals

Mar 14, 2023

+127-258

Commits on Mar 13, 2023

Revert "kvserver: disable assertion 'finished proposal inserted'"
tbg
committed
Revert "kvserver: narrow down 'finishing a proposal with outstanding reproposal'"
tbg
committed
Revert "kvserver: fill gaps in comment near tryReproposeWithNewLeaseIndex"
tbg
committed
Revert "kvserver: hoist early return out of tryReproposeWithNewLeaseIndex"
tbg
committed
Revert "fixup! kvserver: prevent finished proposal from being present in proposals map"
tbg
committed
Revert "kvserver: prevent finished proposal from being present in proposals map"
tbg
committed
Revert "kvserver: improve reproposal assertions and documentation"
tbg
committed
kvserver: resuscitate comment on r.mu.proposals
tbg
committed
kvserver: resuscitate comments in prepareLocalResult
tbg
committed
kvserver: bring back a helpful issue reference
tbg
committed
kvserver: resuscitate some detail on (*Replica).propose
tbg
committed