Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: add log scope to BenchmarkSingleRoundtripWithLatency #99023

Merged
merged 1 commit into from
Mar 20, 2023
Merged

kv: add log scope to BenchmarkSingleRoundtripWithLatency #99023

merged 1 commit into from
Mar 20, 2023

Conversation

nvanbenschoten
Copy link
Member

Informs #98887.

Avoids mixing logs with benchmark results, which breaks benchdiff.

Release note: None

@nvanbenschoten
kv: add log scope to BenchmarkSingleRoundtripWithLatency
e9f92ec 
Informs cockroachdb#98887.

Avoids mixing logs with benchmark results, which breaks benchdiff.

Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner March 20, 2023 13:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten
Copy link
Member Author

bors r=arulajmani

@craig
Copy link
Contributor

craig bot commented Mar 20, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 20, 2023

Build succeeded:

@craig craig bot merged commit cb58230 into cockroachdb:master Mar 20, 2023
@blathers-crl blathers-crl bot mentioned this pull request Mar 20, 2023
Merged
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/benchSingleRoundtripWithLatency branch March 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arulajmani arulajmani arulajmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @cockroach-teamcity @arulajmani