streamingccl: skip acceptance/c2c on remote cluster setup #99574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
msbutler
changed the title
msbutler
force-pushed
the
butler-fix-acceptance-flake
branch
from
54fbdc8
to
c1e8067
Compare
stevendanna
approved these changes
Mar 26, 2023
|
TFTR! bors r=stevendanna |
|
Build failed: |
|
bors r=retry |
|
Build failed: |
|
bors r=retry |
|
Build failed (retrying...): |
|
Build failed: |
acceptance/c2c currently fails when run on a remote cluster. This patch ensures the test gets skipped when run on a remote cluster. There's no need to run the test on a remote cluster because the other c2c roachtests provide sufficient coverage. Fixes cockroachdb#99553 Release note: none
msbutler
force-pushed
the
butler-fix-acceptance-flake
branch
from
c1e8067
to
a8dd57c
Compare
|
let's hope bors likes me this time. bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acceptance/c2c currently fails when run on a remote cluster. This patch ensures the test gets skipped when run on a remote cluster. There's no need to run the test on a remote cluster because the other c2c roachtests provide sufficient coverage.
Fixes #99553
Release note: none