This repository has been archived by the owner on Jul 31, 2021. It is now read-only.
Implement ... expansion for dev test
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickystewart
approved these changes
Feb 16, 2021
| @@ -47,9 +49,38 @@ func mustGetFlagDuration(cmd *cobra.Command, name string) time.Duration { | |||
| return val | |||
| } | |||
|
|
|||
| func parseAddr(addr string) (string, error) { | |||
There was a problem hiding this comment.
Nit: seems like this stuff isn't really related to the other stuff (namely the dev test pkg/... thing), so you could put it in its own commit.
|
(Approved for the new changes in the new commit, not the stuff in #3.) |
And isolate dev-internal debug logging (introducing a mechanism to toggle it), refactor out shared flags, and add some extra validation code for --remote-cache.
irfansharif
force-pushed
the
210212.dot-dot-dot-expansion
branch
from
3d82ab9
to
cfb193a
Compare
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Feb 17, 2021
Discovered these while trying to flesh out cockroachdb/dev#4. We're doing a few things in this commit: - Exclude the testdata dir under pkg/testutils from gazelle/bazel consideration - Fix a few incorrect package resolutions (they were pointing to testdata paths previously). Combining this with cockroachdb/dev#4, now we can use `go test` style "..." expansion in `dev`[*]: dev test pkg/util/... [*]: Though failing tests that are broken under Bazel. Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Feb 17, 2021
60554: jobs: remove WithTxn r=lucy-zhang a=lucy-zhang This commit removes the `Job`'s `WithTxn` method and its `txn` field, which were used to set the next transaction used by a job, and have been a source of many bugs due to setting an incorrect or nil transaction. Now there is an explicit `*kv.Txn` argument on all the `Job` methods that read from the store, where a nil argument still indicates that a new txn should be created. Closes #57534. Release note: None 60558: *,bazel: support `dev test pkg/{...}` expansion r=irfansharif a=irfansharif Discovered these while trying to flesh out cockroachdb/dev#4. We're doing a few things in this commit: - Exclude the testdata dir under pkg/testutils from gazelle/bazel consideration - Fix a few incorrect package resolutions (they were pointing to testdata paths previously). - Break a circular dependency in the uuid package. This only happened in the test target (pkg/util/uuid -> pkg/testutils/skip -> pkg/util/uuid) so flew by undetected earlier. Combining this with cockroachdb/dev#4, now we can use `go test` style "..." expansion in `dev`[*]: dev test pkg/util/... [*]: Though failing tests that are broken under Bazel. Release note: None 60568: docs/tech-notes: update "Statement Execution" and "Building execution plans" sections of "Life of a query" r=raduberinde,yuzefovich a=mneverov docs/tech-notes: update "Statement Execution" and "Building execution plans" sections of "Life of a query" Release note: None Co-authored-by: Lucy Zhang <lucy@cockroachlabs.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com> Co-authored-by: Max Neverov <neverov.max@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And isolate dev-internal debug logging (introducing a mechanism to
toggle it), refactor out shared flags, and add some extra validation
code for --remote-cache.
First commit is from #3, ignore here.