Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: new columns in crdb_internal.zones table #5636

Closed
jseldess opened this issue Oct 17, 2019 · 4 comments
Closed

sql: new columns in crdb_internal.zones table #5636

jseldess opened this issue Oct 17, 2019 · 4 comments
Assignees
@rmloveland @ericharmeling
Labels
C-product-change P-1 High priority; must be done this release
Milestone
19.2

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#40493

From release notes:

The SHOW PARTITIONS statement now displays inherited as well as explicitly set zone configurations for partitions. Also, it is now possible to retrieve full zone configurations via the full_config_sql column in the crdb_internal.zones table, and the new zone_id and subzone_id columns in the crdb_internal.partitions table point to partitions' corresponding zone configurations in crdb_internal.zones. [#40493][#40493] {% comment %}doc{% endcomment %}
@jseldess jseldess added this to the 19.2 milestone Oct 17, 2019
@jseldess jseldess added A-sql P-1 High priority; must be done this release and removed C-product-change A-sql P-1 High priority; must be done this release labels Oct 17, 2019
@jseldess jseldess modified the milestones: 19.2, beta Oct 17, 2019
@jseldess jseldess added A-sql C-product-change P-1 High priority; must be done this release labels Oct 17, 2019
@jseldess jseldess modified the milestones: beta, 19.2 Oct 17, 2019
@ericharmeling ericharmeling changed the title sql: Display inherited constraints in SHOW PARTITIONS sql: new columns in crdb_internal.zones table Oct 17, 2019
@ericharmeling
Copy link
Contributor

I changed the name of this issue to cover what hasn't already been filed/documented (the crdb_internal table).
See #5364 and #5541 - these covered the inherited constraints issue.

Several duplicates of this issue have also popped up (#5530, #5531, #5532).

@rmloveland rmloveland self-assigned this Oct 21, 2019
@rmloveland
Copy link
Contributor

@ericharmeling FYI I'm addressing the crdb_internal.zones part of this issue as part of #4730.

rmloveland added a commit that referenced this issue Oct 21, 2019
@rmloveland
Document how to verify constraint conformance
9277528 
... of your zone configs, that is.

Fixes #4730.

Addresses parts of #2957, #5636.
rmloveland added a commit that referenced this issue Oct 23, 2019
@rmloveland
Document how to check constraint conformance etc.
fe6b138 
Specifically, add docs for the new system tables that provide insight
into:

- Whether data is under-replicated or unavailable

- Violations of data placement requirements

- Which localities have data that is at risk in the event of node
  failure

Fixes #4730.

Addresses #2957, #5636.
@rmloveland rmloveland mentioned this issue Oct 23, 2019
Merged
rmloveland added a commit that referenced this issue Oct 30, 2019
@rmloveland
Document how to check constraint conformance etc.
cc8df51 
Specifically, add docs for the new system tables that provide insight
into:

- Whether data is under-replicated or unavailable

- Violations of data placement requirements

- Which localities have data that is at risk in the event of node
  failure

Fixes #4730.

Addresses #2957, #5636.
rmloveland added a commit that referenced this issue Oct 30, 2019
@rmloveland
Document how to use replication reports
58f0c71 
Specifically, add docs for the new system tables that provide insight
into:

- Whether data is under-replicated or unavailable

- Violations of data placement requirements

- Which localities are critical

Fixes #4730.

Addresses #2957, #5636.

Relates to #4459.
rmloveland added a commit that referenced this issue Nov 4, 2019
@rmloveland
Document how to use replication reports
e70ec20 
Specifically, add docs for the new system tables that provide insight
into:

- Whether data is under-replicated or unavailable

- Violations of data placement requirements

- Which localities are critical

Fixes #4730.

Addresses #2957, #5636.

Relates to #4459.
rmloveland added a commit that referenced this issue Nov 8, 2019
@rmloveland
Document how to use replication reports
7a76945 
Specifically, add docs for the new system tables that provide insight
into:

- Whether data is under-replicated or unavailable

- Violations of data placement requirements

- Which localities are critical

Fixes #4730.

Addresses #2957, #5636.

Relates to #4459.
rmloveland added a commit that referenced this issue Nov 11, 2019
@rmloveland
Document how to use replication reports
167a87f 
Specifically, add docs for the new system tables that provide insight
into:

- Whether data is under-replicated or unavailable

- Violations of data placement requirements

- Which localities are critical

Fixes #4730.

Addresses #2957, #5636.

Relates to #4459.
@rmloveland
Copy link
Contributor

@ericharmeling I've addressed the following bits re: crdb_internal.zones in #5679

Also, it is now possible to retrieve full zone configurations via the full_config_sql column in the crdb_internal.zones table, and the new zone_id and subzone_id columns in the crdb_internal.partitions table point to partitions' corresponding zone configurations in crdb_internal.zones

I think the only thing left is matching up crdb_internal.partitions with crdb_internal.zones, but it looks like that work may happen via #4978 ?

tl;dr: can we close this? or do we need it to stay open to track the zones <-> partitions connection work?

@ericharmeling
Copy link
Contributor

@rmloveland I think we can close this.

crdb_internal.zones is documented in #5679, and we direct users to query crdb_internal.partitions for partition information for "programmatic" purposes in #5722.

And yes, we plan to go into much more detail about all crdb_internal tables with #4978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

@ericharmeling ericharmeling

Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Milestone
19.2
Development

No branches or pull requests
3 participants
@rmloveland @jseldess @ericharmeling