Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to mention that DELETE and UPSERT also use the locking mechanism created for SELECT FOR UPDATE #6699

Closed
rmloveland opened this issue Feb 27, 2020 · 0 comments · Fixed by #7176
Closed

Update docs to mention that DELETE and UPSERT also use the locking mechanism created for SELECT FOR UPDATE #6699

rmloveland opened this issue Feb 27, 2020 · 0 comments · Fixed by #7176
Assignees
@rmloveland
Labels
P-1 High priority; must be done this release

Comments

@rmloveland
Copy link
Contributor

These statements may get implicit SELECT FOR UPDATE locking support by the 20.1 release.

Estimated scope of work:

  • Update docs for the enable_implicit_select_for_update setting to also mention DELETE and UPSERT

See also:
@rmloveland rmloveland added A-kv-storage P-1 High priority; must be done this release labels Apr 15, 2020
rmloveland added a commit that referenced this issue Apr 16, 2020
@rmloveland
Document viewing locking strength with EXPLAIN
7304bbe 
Fixes #6699, #6903, #6920.

Summary of changes:

- Add a new section to EXPLAIN docs called 'Find out if a statement is
  using SELECT FOR UPDATE locking', with an example showing how to
  check.

- List out the SQL statements that have support enabled by default for
  SFU locking.
@rmloveland rmloveland mentioned this issue Apr 16, 2020
Merged
rmloveland added a commit that referenced this issue Apr 21, 2020
@rmloveland
Document viewing locking strength with EXPLAIN
8bc7145 
Fixes #6699, #6903, #6920.

Summary of changes:

- Add a new section to EXPLAIN docs called 'Find out if a statement is
  using SELECT FOR UPDATE locking', with an example showing how to
  check, and a link to the session var to disable it (mostly for
  visibility/learning).

- List out the SQL statements that have support enabled by default for
  SFU locking.
rmloveland added a commit that referenced this issue Apr 21, 2020
@rmloveland
Document viewing locking strength with EXPLAIN
344d85a 
Fixes #6699, #6903, #6920.

Summary of changes:

- Add a new section to EXPLAIN docs called 'Find out if a statement is
  using SELECT FOR UPDATE locking', with an example showing how to
  check, and a link to the session var to disable it (mostly for
  visibility/learning).

- List out the SQL statements that have support enabled by default for
  SFU locking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
P-1 High priority; must be done this release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document viewing locking strength with EXPLAIN cockroachdb/docs
1 participant
@rmloveland