Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back "DOC-2793: Add SSO note for Cloud Console login" #13170

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add back "DOC-2793: Add SSO note for Cloud Console login" #13170

merged 1 commit into from
Mar 4, 2022

Conversation

MichaelTrestman
Copy link
Contributor

This reverts commit fb03219.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Files changed:

_includes/cockroachcloud/prefer-sso.md
cockroachcloud/authentication.md
cockroachcloud/console-access-management.md
cockroachcloud/create-a-serverless-cluster.md
cockroachcloud/create-your-cluster.md

@MichaelTrestman
Copy link
Contributor Author

These changes were reviewed as #13163

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Netlify Preview

🔨 Explore the source changes: 965c34e

🔍 Inspect the deploy log: https://app.netlify.com/sites/cockroachdb-docs/deploys/6222146e791b8e0008441a6c

😎 Browse the preview: https://deploy-preview-13170--cockroachdb-docs.netlify.app

@MichaelTrestman MichaelTrestman merged commit 18108fd into master Mar 4, 2022
taroface
taroface reviewed Mar 7, 2022
View reviewed changes
_includes/cockroachcloud/prefer-sso.md
@@ -0,0 +1,7 @@
{{site.data.alerts.callout_info}}
We recommend that {{ site.data.products.db }} Console users login with Single Sign-On (SSO), with two-factor authentication (2FA) enabled for the SSO provider. This prevents potential attackers from using stolen credentials to accesss or tamper with your critical data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login -> log in

taroface
taroface reviewed Mar 7, 2022
View reviewed changes
cockroachcloud/authentication.md

## Cloud Console authentication

You may login to the [{{ site.data.products.db }} Console](https://cockroachlabs.cloud/) with a username and password, or using SSO.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login -> log in

@taroface
Copy link
Contributor

taroface commented Mar 7, 2022

These changes were reviewed as #13163

@MichaelTrestman These changes were reviewed but weren't approved. See above comments that I also had on the previous PR.

For future PRs, please do not merge until all reviewers have approved, i.e., all review comments have been addressed.

@lnhsingh lnhsingh deleted the GitHub-SSO-for-cloud branch June 23, 2022 14:03
@ekmixon ekmixon mentioned this pull request Dec 1, 2023
Open
@ekmixon ekmixon mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taroface taroface taroface left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelTrestman @cockroach-teamcity @taroface