Add storage.wal.fsync.latency and other metrics
#19425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmloveland
force-pushed
the
20250306-DOC-11996-storage-essential-metrics
branch
from
2392785 to
5d8469e
Compare
rmloveland
changed the title
storage.wal.fsync.latency to metricsstorage.wal.fsync.latency and other metrics
Fixes DOC-11996 Adds the following metrics to the docs: - storage.wal.fsync.latency - rebalancing.range.rebalances - rebalancing.replicas.queriespersecond
rmloveland
force-pushed
the
20250306-DOC-11996-storage-essential-metrics
branch
from
5d8469e to
78c6838
Compare
rmloveland
commented
Mar 10, 2025
kvoli
reviewed
Mar 13, 2025
kvoli
approved these changes
Mar 18, 2025
jbowens
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
lgtm
seconding @sumeerbhola's slack comment that maybe we should update the WAL failover page to reference storage.wal.failover.write_and_sync.latency. The tl;dr is that storage.wal.fsync.latency monitors the latencies of WAL files. If you have WAL failover enabled and are failing over, storage.wal.fsync.latency will include the latency of the stalled primary. The storage.wal.failover.write_and_sync.latency metric is up one level, and during the failover will report the latency actually observed by higher-levels (which should be ~equivalent to the latency of the secondary).
|
thanks for the review @jbowens! and thanks for the additional info, i've filed https://cockroachlabs.atlassian.net/browse/DOC-13184 to update the WAL failover page with that metric as well update: as part of that work i'll also plan to come back and update this list of metrics as well if we decide that's appropriate |
taroface
approved these changes
Apr 10, 2025
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
rmloveland
force-pushed
the
20250306-DOC-11996-storage-essential-metrics
branch
from
21feb5c to
c6eb09f
Compare
rmloveland
pushed a commit
to rmloveland/integrations-extras
that referenced
this pull request
Sep 16, 2025
Adds the following metrics using their DataDog names: - `storage_wal_fsync_latency` - `rebalancing_replicas_queriespersecond` - `range_merges` - `rebalancing_lease_transfers` - `rebalancing_range_rebalances` See also cockroachdb/docs#19425, where these were added to the CockroachDB docs.
5 tasks
rmloveland
pushed a commit
to rmloveland/integrations-extras
that referenced
this pull request
Oct 2, 2025
Adds the following metrics using their DataDog names: - `storage_wal_fsync_latency` - `rebalancing_replicas_queriespersecond` - `range_merges` - `rebalancing_lease_transfers` - `rebalancing_range_rebalances` See also cockroachdb/docs#19425, where these were added to the CockroachDB docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-11996