Fix/v25.4 paths #20284
Open
Fix/v25.4 paths #20284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `versions.csv` entry, but not yet any releases.yml entry, for the new major version.
- Release info plugin: Add support for having versioned docs and versions.csv entry without any releases.yml entries.
Previously this would yield a `NoMethodError` and block the build
- Version switcher: Filter dropdowns to only show versions that have releases (testing or prod) in releases.yml
- Prevents "No releases available" from appearing in the menu across versions, during this pre-alpha state.
These changes ensure that we can merge and preview docs for the forthcoming version before it has reached alpha,
while leaving it hidden from public view, only accessible via direct /<version> URLs. Note that the /dev alias will not work
until we set the new version as `dev` in _config_cockroachdb.yml upon the first alpha release.
- Validate all release dates before processing to prevent Date.parse crashes - Validate required docker configuration exists before accessing nested hash - Fail fast with descriptive error messages instead of silent data corruption - Error messages include release name and major version for easy debugging Addresses build stability concerns while ensuring data quality by catching malformed entries in releases.yml during build time rather than at runtime. Fixes potential crashes from: - nil/empty/invalid release_date values - missing docker.docker_image configuration
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.