Skip to content

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Oct 2, 2025

Follow-up to https://cockroachlabs.atlassian.net/browse/DOC-12063

  • Create new version of the new-release-downloads-and-docker-image.md include that adds IBM release info (conditionally; doesn't include in non-production releases)
  • Add IBM tab to list of OS tabs on the releases/ page with logic displaying different content based on the version number and release status:
    • Releases prior to v25.3 state that IBM is not available until 25.3+
    • Testing releases state that IBM is only available on production releases.
  • Rename the release-downloads-x.md includes to generally timestamp them, which seems more scalable than listing all of the included downloads in the name.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 67d522d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68e7f65d7e52a90008314d70

Copy link

github-actions bot commented Oct 2, 2025

Files changed:

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 67d522d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68e7f65dfcc89a00088438c6

@jhlodin
Copy link
Contributor Author

jhlodin commented Oct 2, 2025

@mikeCRL need your help with the releases/index.md page logic. The page does not seem to like rendering a tab-selector with options that are not available in the other tab-selectors on the page.

@jhlodin jhlodin requested a review from mikeCRL October 2, 2025 20:45
Copy link

netlify bot commented Oct 2, 2025

Netlify Preview

Name Link
🔨 Latest commit 67d522d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68e7f65d4c1c9300088bc3e7
😎 Deploy Preview https://deploy-preview-20480--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jhlodin jhlodin force-pushed the jl/doc-12063-followup branch from fcecdae to 79580b2 Compare October 6, 2025 19:42
@jhlodin jhlodin force-pushed the jl/doc-12063-followup branch from 79580b2 to 550c797 Compare October 7, 2025 18:06
@jhlodin jhlodin marked this pull request as ready for review October 7, 2025 18:28
@jhlodin
Copy link
Contributor Author

jhlodin commented Oct 7, 2025

Rendering on the page for a specific release. This section does not appear prior to 25.3 or on pre-production releases (like 25.4, currently):
Screenshot 2025-10-07 at 2 32 38 PM

Rendering on the general releases page for an available production release:
Screenshot 2025-10-07 at 2 33 53 PM

Rendering on the general releases page for an older release:
Screenshot 2025-10-07 at 2 34 24 PM

Rendering on the general releases page for an upcoming, testing-only release:
Screenshot 2025-10-07 at 2 34 54 PM

@@ -0,0 +1,113 @@
{% comment %}This include is used only in v23.3.2 and above. Newer versions use release-downloads-docker-image.md. {% endcomment %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlodin would you say this is mostly a copy of new-release-downloads-docker-image.md modified with some new IBM-specific logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct. It might be wise to rename that old file because new-* is now a misnomer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 great idea

"new" is ... always a less than great idea :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

@jhlodin jhlodin force-pushed the jl/doc-12063-followup branch from eab04b1 to 67d522d Compare October 9, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants