-
Notifications
You must be signed in to change notification settings - Fork 474
Add IBM sections to release downloads and info for 25.3.2+ prod releases #20480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
@mikeCRL need your help with the |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
fcecdae
to
79580b2
Compare
79580b2
to
550c797
Compare
@@ -0,0 +1,113 @@ | |||
{% comment %}This include is used only in v23.3.2 and above. Newer versions use release-downloads-docker-image.md. {% endcomment %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhlodin would you say this is mostly a copy of new-release-downloads-docker-image.md
modified with some new IBM-specific logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes correct. It might be wise to rename that old file because new-*
is now a misnomer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 great idea
"new" is ... always a less than great idea :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM
Add IBM section and links to applicable releases
eab04b1
to
67d522d
Compare
Follow-up to https://cockroachlabs.atlassian.net/browse/DOC-12063
new-release-downloads-and-docker-image.md
include that adds IBM release info (conditionally; doesn't include in non-production releases)releases/
page with logic displaying different content based on the version number and release status: