-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise basic hardware recs and add cloud-specific recs #2312
Conversation
I'm having second thoughts about this because the AWS |
d225352
to
0260395
Compare
0260395
to
7bad52c
Compare
7bad52c
to
ce8c5db
Compare
ce8c5db
to
7f444a0
Compare
@bdarnell, @mberhault, please review the revised basic and new cloud-specific hardware recommendations. Before adding them to the cloud tutorials (and replicated to v2.0 docs), I'd like to know what's wrong, what needs expansion, etc. Thanks very much for the help thus far. |
7f444a0
to
f9dc979
Compare
1 similar comment
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. v1.1/recommended-production-settings.md, line 20 at r1 (raw file):
We should clarify that the number of nodes and the replication factor are two different things. The replication factor (set via zone configs) should be an odd number, while you can use any number of nodes (as long as you have at least as many nodes as your replication factor). v1.1/recommended-production-settings.md, line 35 at r1 (raw file):
Add "virtual" before "machines" here to clarify that this applies to virtualized cloud scenarios and not bare metal. v1.1/recommended-production-settings.md, line 62 at r1 (raw file):
If we're going to list machine types to stay away from on azure we also need to list A-series (HDD, data corruption) and D-series (irregular disk performance). Comments from Reviewable |
f9dc979
to
12cf80e
Compare
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions. v1.1/recommended-production-settings.md, line 20 at r1 (raw file): Previously, bdarnell (Ben Darnell) wrote…
If it's ok with you, I'm going to revise/expand this section in a follow-up PR. Already have plans to provide sample cluster patterns and more details about fault tolerance, so I assume this section will change at least a bit. v1.1/recommended-production-settings.md, line 35 at r1 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Done. v1.1/recommended-production-settings.md, line 62 at r1 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Done. Comments from Reviewable |
12cf80e
to
1297c07
Compare
Fixes #2181
Fixes #1132
Fixes #1356