Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movr workload #5713

Merged
merged 1 commit into from
Oct 29, 2019
Merged

movr workload #5713

merged 1 commit into from
Oct 29, 2019

Conversation

ericharmeling
Copy link
Contributor

Fixes #5687.

  • Changed wording around movr workload.
  • Added new flags for cockroach workload run movr.
  • Added example for cockroach workload run movr.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@@ -63,7 +63,7 @@ Workload | Description
`bank` | Models a set of accounts with currency balances.<br><br>For this workload, you run `workload init` to load the schema and then `workload run` to generate data.
`intro` | Loads an `intro` database, with one table, `mytable`, with a hidden message.<br><br>For this workload, you run only `workload init` to load the data. The `workload run` subcommand is not applicable.
`kv` | Reads and writes to keys spread (by default, uniformly at random) across the cluster.<br><br>For this workload, you run `workload init` to load the schema and then `workload run` to generate data.
`movr` | Loads a `movr` database, with several tables of data for the [MovR example application](movr.html).<br><br>For this workload, you run only `workload init` to load the data. The `workload run` subcommand is not applicable.
`movr` | <span class="version-tag">New in v19.2:</span> Simulates a workload for the [MovR example application](movr.html).<br><br>For this workload, you run `workload init` to load the schema and then `workload run` to generate data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this should link down to the description of flags. (I realize nothing else on this page does that so maybe we should file an improvement issue for now?)

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perl -E '@xs = (27, 25.75, 29, 27.25); do {say chr ($_*4)} for @xs;'

- Added movr workload flags
- Added movr workload example
- Added links to flag descriptions
Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rmloveland)


v19.2/cockroach-workload.md, line 66 at r1 (raw file):

Previously, rmloveland (Rich Loveland) wrote…

It feels like this should link down to the description of flags. (I realize nothing else on this page does that so maybe we should file an improvement issue for now?)

Done.

@ericharmeling ericharmeling merged commit 3857fc9 into master Oct 29, 2019
@ericharmeling ericharmeling deleted the workload-run-movr branch October 29, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document cockroach workload run movr
3 participants