Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that stats are collected on table creation #5796

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Note that stats are collected on table creation #5796

merged 1 commit into from
Nov 8, 2019

Conversation

rmloveland
Copy link
Contributor

Fixes #4894.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7a7ecb85a874fc4228988a6e549f11c468c8e3d2/

Edited pages:

@rmloveland
Copy link
Contributor Author

@rytaft it's a small change but I don't want to introduce a subtle error in the language. PTAL at your convenience.

rytaft
rytaft approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rmloveland
Copy link
Contributor Author

TFTR Becca!

@rmloveland rmloveland merged commit 94fa5f1 into master Nov 8, 2019
@rmloveland rmloveland deleted the 20191106-collect-stats-on-table-creation branch November 8, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytaft rytaft rytaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: always collect stats after a table is created
3 participants
@rmloveland @cockroach-teamcity @rytaft