Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering by arrays #7934

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Ordering by arrays #7934

merged 1 commit into from
Aug 5, 2020

Conversation

ericharmeling
Copy link
Contributor

Fixes #7744.
Fixes #7621.

  • Updated example output of examples on ARRAY docs page.
  • Added new ordering by array example to ARRAY docs page.
  • Removed note on limitation on ordering by arrays.

@ericharmeling ericharmeling requested a review from rohany August 5, 2020 13:42
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8ce4c6657e8f24c907684f2db40477b7a53c115d/

Edited pages:

@ericharmeling ericharmeling requested a review from lnhsingh August 5, 2020 14:31
lnhsingh
lnhsingh reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @lnhsingh)

@ericharmeling ericharmeling merged commit 83d2912 into master Aug 5, 2020
@ericharmeling ericharmeling deleted the order-by-array branch August 5, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnhsingh lnhsingh lnhsingh left review comments

@rohany rohany rohany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ericharmeling @cockroach-teamcity @rohany @lnhsingh