ALTER TYPE support #8022

ericharmeling · 2020-08-18T20:01:58Z

Fixes #4753.
Fixes #7852.
Fixes #7633.

cockroach-teamcity · 2020-08-18T20:02:05Z

This change is

cockroach-teamcity · 2020-08-18T20:07:02Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/56fc7e21b5533d78074b3aaf57e2724871944123/

Edited pages:

RichardJCai

General comment, some of the pages are called ALTER TYPE but we'll actually have ALTER TYPE operations for user defined types soon - I think these ALTER TYPEs should be renamed to ALTER COLUMN TYPE

RichardJCai · 2020-08-18T20:52:30Z

v20.2/experimental-features.md

@@ -19,6 +19,7 @@ The table below lists the experimental session settings that are available.  For

 | Variable                            | Default Value | Description                                                                                                                                                                                                                                                                                             |
 |-------------------------------------+---------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `enable_experimental_alter_column_type_general`       | `'false'`       |  If set to `'true'`, enables [column type altering](#alter-column-type).                                                                                                                                                                                   |


I think it would be useful to specify it enables ALTER COLUMN TYPE support for general cases with some limitations or something along those lines.

Also I don't think the hyperlink is working properly here.

RichardJCai · 2020-08-18T20:52:36Z

v19.2/alter-type.md

@@ -31,7 +35,7 @@ The user must have the `CREATE` [privilege](authorization.html#assign-privileges
 |-----------|-------------
 | `table_name` | The name of the table with the column whose data type you want to change.
 | `column_name` | The name of the column whose data type you want to change.
-| `typename` | The new [data type](data-types.html) you want to use.
+| `typename` | The new data type you want to use.<br>`ALTER TABLE ... ALTER TYPE` and [`ALTER TABLE ... ALTER COLUMN ... SET DATA TYPE`](alter-column.html) are aliases.


I think ALTER TABLE ... ALTER TYPE should be replaced with ALTER TABLE ... ALTER ... TYPE since a col name should go between.
Applies to the other pages as well

Also [SET DATA] is optional to provide.

RichardJCai · 2020-08-18T20:52:38Z

v19.2/alter-type.md

-## Considerations
+## Limitations
+
+In CockroachDB versions < v20.2, support for altering column types is limited to increasing the precision of the current type of a column. You cannot convert the column type to another data type, or decrease the precision of the column type.


Is it worth mentioning there is no errors for no-ops as well - changing the column type from the current type to itself.

ericharmeling

TFTR, @RichardJCai !

we'll actually have ALTER TYPE operations for user defined types soon

Since this is the case, I've consolidated the alter-type and alter-column pages, since ALTER TYPE is actually a subcommand of ALTER COLUMN. Please rereview.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @RichardJCai)

v19.2/alter-type.md, line 15 at r1 (raw file):

Previously, RichardJCai (Richard Cai) wrote…

Is it worth mentioning there is no errors for no-ops as well - changing the column type from the current type to itself.

Done.

v19.2/alter-type.md, line 38 at r1 (raw file):

Previously, RichardJCai (Richard Cai) wrote…

I think ALTER TABLE ... ALTER TYPE should be replaced with ALTER TABLE ... ALTER ... TYPE since a col name should go between.
Applies to the other pages as well

Also [SET DATA] is optional to provide.

Done.

v20.2/experimental-features.md, line 22 at r1 (raw file):

Previously, RichardJCai (Richard Cai) wrote…

I think it would be useful to specify it enables ALTER COLUMN TYPE support for general cases with some limitations or something along those lines.

Also I don't think the hyperlink is working properly here.

Done.

cockroach-teamcity · 2020-08-19T15:54:48Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a1daa50828bd5bbcb1f3bfd1bce6688d10dfea0a/

Edited pages:

cockroach-teamcity · 2020-08-19T21:36:48Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0046bdac0a10e0b5111e9cfda05a1448461e9789/

Edited pages:

cockroach-teamcity · 2020-08-20T15:36:12Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f5666a2e70a5af97540435647c868046a8179dbd/

Edited pages:

RichardJCai

Looks mostly good to me, some minor comments.

RichardJCai · 2020-08-20T19:35:01Z

v20.2/alter-column.md

+(1 row)
+~~~
+
+### Create a new computed column value


I would title this as Change a columns type using an expression

RichardJCai · 2020-08-20T19:35:14Z

v20.1/alter-column.md

+
+You can use `ALTER COLUMN TYPE` if the following conditions are met:
+
+- The on-disk representation of the column remains unchanged. For example, you cannot change the column data type from `STRING` to an `INT`, even if the string is just a number.


I would just remove the note on even if the string is just a number.

RichardJCai · 2020-08-20T19:37:16Z

v20.2/alter-table.md

@@ -19,9 +19,7 @@ Subcommand | Description | Can combine with other subcommands?
 [`ADD COLUMN`](add-column.html) | Add columns to tables. | Yes
 [`ADD CONSTRAINT`](add-constraint.html) | Add constraints to columns. | Yes
 [`ALTER COLUMN`](alter-column.html) | Change or drop a column's [`DEFAULT` constraint](default-value.html) or [`NOT NULL` constraint](not-null.html). | Yes


This is sort of out dated now. The description only covers some cases. Maybe we should actually have the description be more vague and have them click through to the ALTER COLUMN page.

ericharmeling

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @RichardJCai)

v20.1/alter-column.md, line 48 at r2 (raw file):

Previously, RichardJCai (Richard Cai) wrote…

I would just remove the note on even if the string is just a number.

Done.

v20.2/alter-column.md, line 202 at r2 (raw file):

Previously, RichardJCai (Richard Cai) wrote…

I would title this as Change a columns type using an expression

Done.

v20.2/alter-table.md, line 21 at r2 (raw file):

Previously, RichardJCai (Richard Cai) wrote…

This is sort of out dated now. The description only covers some cases. Maybe we should actually have the description be more vague and have them click through to the ALTER COLUMN page.

Done.

cockroach-teamcity · 2020-08-24T16:19:41Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/352cc24d70a3fad1029f07b109db5cd4fc7abadd/

Edited pages:

lnhsingh

LGTM - just a couple of minor edits!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling, @lnhsingh, and @RichardJCai)

v19.2/alter-column.md, line 11 at r3 (raw file):

- Set, change, or drop a column's [`DEFAULT` constraint](default-value.html)
- Set or drop a column's [`NOT NULL` constraint](not-null.html)
- Increase the precision of the column's [data type](data-types.html).

nit: Remove period (or add periods to the other bullets)

v19.2/alter-column.md, line 57 at r3 (raw file):

- `ALTER TABLE ... ALTER COLUMN SET DATA TYPE`

For an example of `ALTER COLUMN TYPE`, [Increase a column type's precision](#increase-a-column-types-precision).

nit: "For an example of ALTER COLUMN TYPE, see Increase..."

v20.1/alter-column.md, line 11 at r3 (raw file):

- Set, change, or drop a column's [`DEFAULT` constraint](default-value.html)
- Set or drop a column's [`NOT NULL` constraint](not-null.html)
- Increase the precision of the column's [data type](data-types.html).

nit: Remove period (or add to other bullets)

v20.1/alter-column.md, line 57 at r3 (raw file):

- `ALTER TABLE ... ALTER COLUMN SET DATA TYPE`

For an example of `ALTER COLUMN TYPE`, [Increase a column type's precision](#increase-a-column-types-precision).

nit: add "see Increase..."

v20.1/alter-column.md, line 83 at r3 (raw file):

### Set `NOT NULL` constraint

<span class="version-tag">New in v19.2:</span> Setting the  [`NOT NULL` constraint](not-null.html) specifies that the column cannot contain `NULL` values.

Should this flag be here?

v20.2/alter-column.md, line 10 at r3 (raw file):

- Set, change, or drop a column's [`DEFAULT` constraint](default-value.html)
- Set or drop a column's [`NOT NULL` constraint](not-null.html)

Should this also have the new bullet you added on other versions?

- Increase the precision of the column's [data type](data-types.html)

ericharmeling

TFTR @lnhsingh !

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lnhsingh and @RichardJCai)

v19.2/alter-column.md, line 11 at r3 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

nit: Remove period (or add periods to the other bullets)

Done.

v19.2/alter-column.md, line 57 at r3 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

nit: "For an example of ALTER COLUMN TYPE, see Increase..."

Done.

v20.1/alter-column.md, line 11 at r3 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

nit: Remove period (or add to other bullets)

Done.

v20.1/alter-column.md, line 57 at r3 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

nit: add "see Increase..."

Done.

v20.1/alter-column.md, line 83 at r3 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

Should this flag be here?

Nooo - thanks! Removed.

v20.2/alter-column.md, line 10 at r3 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

Should this also have the new bullet you added on other versions?

- Increase the precision of the column's [data type](data-types.html)

It should not, because the other versions only support increasing the precision of the column data type, which was not clearly documented before (hence the added bullet in v19.2 and v20.1). v20.2 supports changing the column data type (which includes changing its precision).

cockroach-teamcity · 2020-08-25T18:09:25Z

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/445da4af68ce4ffa3c04843b47d4799ef8e6f6fd/

Edited pages:

ericharmeling requested a review from RichardJCai August 18, 2020 20:01

RichardJCai suggested changes Aug 18, 2020

View reviewed changes

RichardJCai reviewed Aug 18, 2020

View reviewed changes

ericharmeling force-pushed the alter-type branch from 56fc7e2 to a1daa50 Compare August 19, 2020 15:44

ericharmeling requested a review from RichardJCai August 19, 2020 15:45

ericharmeling commented Aug 19, 2020

View reviewed changes

ericharmeling force-pushed the alter-type branch from a1daa50 to 0046bda Compare August 19, 2020 21:32

ericharmeling force-pushed the alter-type branch from 0046bda to f5666a2 Compare August 20, 2020 15:24

RichardJCai reviewed Aug 20, 2020

View reviewed changes

ericharmeling force-pushed the alter-type branch from f5666a2 to 352cc24 Compare August 24, 2020 16:14

ericharmeling requested a review from RichardJCai August 24, 2020 16:14

ericharmeling commented Aug 24, 2020

View reviewed changes

ericharmeling requested a review from lnhsingh August 24, 2020 16:21

lnhsingh reviewed Aug 24, 2020

View reviewed changes

ALTER TYPE support

445da4a

ericharmeling force-pushed the alter-type branch from 352cc24 to 445da4a Compare August 25, 2020 18:05

ericharmeling requested a review from lnhsingh August 25, 2020 18:05

ericharmeling commented Aug 25, 2020

View reviewed changes

ericharmeling merged commit 687a980 into master Aug 25, 2020

ericharmeling deleted the alter-type branch August 25, 2020 18:28

ericharmeling mentioned this pull request Sep 16, 2020

sql: support alter type owner #8325

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ALTER TYPE support #8022

ALTER TYPE support #8022

ericharmeling commented Aug 18, 2020

cockroach-teamcity commented Aug 18, 2020

cockroach-teamcity commented Aug 18, 2020

RichardJCai left a comment

RichardJCai Aug 18, 2020

RichardJCai Aug 18, 2020

RichardJCai Aug 18, 2020

ericharmeling left a comment

cockroach-teamcity commented Aug 19, 2020

cockroach-teamcity commented Aug 19, 2020

cockroach-teamcity commented Aug 20, 2020

RichardJCai left a comment

RichardJCai Aug 20, 2020

RichardJCai Aug 20, 2020

RichardJCai Aug 20, 2020

ericharmeling left a comment

cockroach-teamcity commented Aug 24, 2020

lnhsingh left a comment

ericharmeling left a comment

cockroach-teamcity commented Aug 25, 2020


		You can use `ALTER COLUMN TYPE` if the following conditions are met:

		- The on-disk representation of the column remains unchanged. For example, you cannot change the column data type from `STRING` to an `INT`, even if the string is just a number.

ALTER TYPE support #8022

ALTER TYPE support #8022

Conversation

ericharmeling commented Aug 18, 2020

cockroach-teamcity commented Aug 18, 2020

cockroach-teamcity commented Aug 18, 2020

RichardJCai left a comment

Choose a reason for hiding this comment

RichardJCai Aug 18, 2020

Choose a reason for hiding this comment

RichardJCai Aug 18, 2020

Choose a reason for hiding this comment

RichardJCai Aug 18, 2020

Choose a reason for hiding this comment

ericharmeling left a comment

Choose a reason for hiding this comment

cockroach-teamcity commented Aug 19, 2020

cockroach-teamcity commented Aug 19, 2020

cockroach-teamcity commented Aug 20, 2020

RichardJCai left a comment

Choose a reason for hiding this comment

RichardJCai Aug 20, 2020

Choose a reason for hiding this comment

RichardJCai Aug 20, 2020

Choose a reason for hiding this comment

RichardJCai Aug 20, 2020

Choose a reason for hiding this comment

ericharmeling left a comment

Choose a reason for hiding this comment

cockroach-teamcity commented Aug 24, 2020

lnhsingh left a comment

Choose a reason for hiding this comment

ericharmeling left a comment

Choose a reason for hiding this comment

cockroach-teamcity commented Aug 25, 2020