Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-column statistics #8091

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Multi-column statistics #8091

merged 1 commit into from
Aug 27, 2020

Conversation

ericharmeling
Copy link
Contributor

Fixes #4798.
Fixes #7611.

  • Documented multi-column statistics support in v20.2
  • Updated STATISTICS statement examples and notes in v19.2, v20.1, and v20.2

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7ca8bd99c7ba41cc3fd136240066a7b0b77d080a/

Edited pages:

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3a7ce058a10b859bca292a28ade988e49679433b/

Edited pages:

rytaft
rytaft approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

v19.2/create-statistics.md, line 66 at r1 (raw file):

~~~

Note that statistics are automatically collected for all columns in the `rides` table, making the `revenue_stats` statistics a duplicate of the statistics automatically collected on the `rides` column.

rides column -> revenue column

v20.1/create-statistics.md, line 66 at r1 (raw file):

~~~

Note that statistics are automatically collected for all columns in the `rides` table, making the `revenue_stats` statistics a duplicate of the statistics automatically collected on the `rides` column.

ditto

v20.2/create-statistics.md, line 71 at r1 (raw file):

~~~

Note that statistics are automatically collected for all columns in the `rides` table, making the `revenue_stats` statistics a duplicate of the statistics automatically collected on the `rides` column.

ditto

ericharmeling
ericharmeling commented Aug 26, 2020
View reviewed changes
Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR @rytaft !

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @rytaft)

v19.2/create-statistics.md, line 66 at r1 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

rides column -> revenue column

Done.

v20.1/create-statistics.md, line 66 at r1 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

ditto

Done.

v20.2/create-statistics.md, line 71 at r1 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

ditto

Done.

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7c2a698daa3ee9cc986281f84c62eb7f95772eb2/

Edited pages:

rytaft
rytaft approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @lnhsingh)

lnhsingh
lnhsingh approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @lnhsingh)

@ericharmeling ericharmeling merged commit 7f96b66 into master Aug 27, 2020
@ericharmeling ericharmeling deleted the multi-column-stats branch August 27, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytaft rytaft rytaft approved these changes

@lnhsingh lnhsingh lnhsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: collect multi-column stats on index prefixes Multi-column stats
4 participants
@ericharmeling @cockroach-teamcity @rytaft @lnhsingh