Removed "experimental" from experimental_follower_read_timestamp #8816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ericharmeling
changed the title
rmloveland
reviewed
Nov 3, 2020
v20.2/follower-reads.md
Outdated
| @@ -65,14 +65,14 @@ To verify that your cluster is performing follower reads: | |||
|
|
|||
| ### Run queries that use follower reads | |||
|
|
|||
| <a name="experimental-follower-read-timestamp"></a> | |||
| <a name="follower-read-timestamp"></a> | |||
There was a problem hiding this comment.
FWIW this anchor can be deleted, nothing is pointing to it (I was just making this exact PR until I saw this lol)
There was a problem hiding this comment.
Ah! I see - sorry to step on your toes with this PR!
There was a problem hiding this comment.
You did not - in fact I'm thrilled - thanks for doing this
There was a problem hiding this comment.
NP! Just removed that anchor.
ericharmeling
force-pushed
the
removed-experimental-from-experimental_follower_reads_timestamp
branch
from
4c1dd88
to
adf19b6
Compare
andreimatei
reviewed
Nov 4, 2020
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @rmloveland)
lnhsingh
reviewed
Nov 5, 2020
There was a problem hiding this comment.
Reviewable status:
ericharmeling
deleted the
removed-experimental-from-experimental_follower_reads_timestamp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8166.
FYI @rmloveland