Skip to content

Add status.Errorf to the gRPC Wrappers #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

Add status.Errorf to the gRPC Wrappers #110

merged 2 commits into from
Jun 5, 2023

Conversation

michael-james-holloway
Copy link
Contributor

@michael-james-holloway michael-james-holloway commented Jun 3, 2023 •
edited by cockroach-dev-inf
Loading

Mirrors the official grpc-go status package's status.Errorf defined here.

This change is Reviewable

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

knz
knz approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks!

@knz knz merged commit f6b9c79 into cockroachdb:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@knz knz knz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-james-holloway @cockroach-teamcity @knz